test_duty_schedule.py 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552
  1. """值班排班服务单测"""
  2. from datetime import date
  3. from types import SimpleNamespace
  4. from unittest.mock import MagicMock
  5. import pytest
  6. from app.models.duty_models import (
  7. DUTY_STAFF_ROLE_ID,
  8. DUTY_STAFF_ROLE_NAME,
  9. LINK_CLOSED,
  10. LINK_OPEN,
  11. SHIFT_EVENING,
  12. SHIFT_LABELS,
  13. SHIFT_MORNING,
  14. SOURCE_ASSIGN,
  15. SOURCE_GRAB,
  16. )
  17. from app.schemas.duty import DutyAssignmentIn, DutyDaySaveBody, DutySlotSaveIn
  18. from app.services.duty_schedule import (
  19. DutyBizError,
  20. assert_user_is_duty_staff,
  21. grab,
  22. list_duty_staff_users,
  23. normalize_person_name,
  24. resolve_duty_staff_role_id,
  25. save_day,
  26. )
  27. def test_normalize_person_name_ok():
  28. assert normalize_person_name(" 张三 ") == "张三"
  29. def test_normalize_person_name_empty():
  30. with pytest.raises(DutyBizError, match="姓名"):
  31. normalize_person_name(" ")
  32. def test_normalize_person_name_too_long():
  33. with pytest.raises(DutyBizError, match="姓名"):
  34. normalize_person_name("啊" * 21)
  35. def test_shift_labels():
  36. assert SHIFT_LABELS[SHIFT_MORNING] == "早班"
  37. def test_grab_rejects_when_full():
  38. db = MagicMock()
  39. day = SimpleNamespace(
  40. id="day1",
  41. tenant_no="t1",
  42. link_status=LINK_OPEN,
  43. duty_date=date(2026, 8, 20),
  44. access_token="tok",
  45. del_flag=0,
  46. )
  47. slot = SimpleNamespace(
  48. id="slot1",
  49. duty_day_id="day1",
  50. shift_type=SHIFT_EVENING,
  51. capacity=1,
  52. del_flag=0,
  53. )
  54. user = SimpleNamespace(
  55. id="u1",
  56. tenant_no="t1",
  57. nick_name="李四",
  58. user_no="lisi",
  59. status="1",
  60. del_flag=0,
  61. )
  62. day_q = MagicMock()
  63. day_q.filter.return_value.with_for_update.return_value.first.return_value = day
  64. slot_q = MagicMock()
  65. slot_q.filter.return_value.with_for_update.return_value.first.return_value = slot
  66. user_q = MagicMock()
  67. user_q.filter.return_value.first.return_value = user
  68. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  69. role_q = MagicMock()
  70. role_q.filter.return_value.first.return_value = role
  71. ur_q = MagicMock()
  72. ur_q.filter.return_value.first.return_value = SimpleNamespace(user_id="u1", role_id=DUTY_STAFF_ROLE_ID)
  73. def query_side_effect(model):
  74. name = getattr(model, "__name__", str(model))
  75. if name == "DutyDay":
  76. return day_q
  77. if name == "DutySlot":
  78. return slot_q
  79. if name == "SysUser":
  80. return user_q
  81. if name == "SysRole":
  82. return role_q
  83. if name == "SysUserRole":
  84. return ur_q
  85. # DutyAssignment count / duplicate
  86. aq = MagicMock()
  87. aq.filter.return_value.count.return_value = 1
  88. aq.filter.return_value.first.return_value = None
  89. return aq
  90. db.query.side_effect = query_side_effect
  91. with pytest.raises(DutyBizError, match="名额已满"):
  92. grab(db, "tok", SHIFT_EVENING, "u1")
  93. def test_grab_rejects_when_closed():
  94. db = MagicMock()
  95. day = SimpleNamespace(
  96. id="day1",
  97. tenant_no="t1",
  98. link_status=LINK_CLOSED,
  99. duty_date=date(2026, 8, 20),
  100. access_token="tok",
  101. del_flag=0,
  102. )
  103. day_q = MagicMock()
  104. day_q.filter.return_value.with_for_update.return_value.first.return_value = day
  105. db.query.return_value = day_q
  106. with pytest.raises(DutyBizError, match="关闭"):
  107. grab(db, "tok", SHIFT_EVENING, "u1")
  108. def test_grab_rejects_invalid_user():
  109. db = MagicMock()
  110. day = SimpleNamespace(
  111. id="day1",
  112. tenant_no="t1",
  113. link_status=LINK_OPEN,
  114. duty_date=date(2026, 8, 20),
  115. access_token="tok",
  116. del_flag=0,
  117. )
  118. day_q = MagicMock()
  119. day_q.filter.return_value.with_for_update.return_value.first.return_value = day
  120. user_q = MagicMock()
  121. user_q.filter.return_value.first.return_value = None
  122. def query_side_effect(model):
  123. name = getattr(model, "__name__", str(model))
  124. if name == "DutyDay":
  125. return day_q
  126. if name == "SysUser":
  127. return user_q
  128. return MagicMock()
  129. db.query.side_effect = query_side_effect
  130. with pytest.raises(DutyBizError, match="用户|无效|不存在"):
  131. grab(db, "tok", SHIFT_EVENING, "bad-user")
  132. def test_grab_rejects_duplicate_same_shift():
  133. db = MagicMock()
  134. day = SimpleNamespace(
  135. id="day1",
  136. tenant_no="t1",
  137. link_status=LINK_OPEN,
  138. duty_date=date(2026, 8, 20),
  139. access_token="tok",
  140. del_flag=0,
  141. )
  142. slot = SimpleNamespace(
  143. id="slot1",
  144. duty_day_id="day1",
  145. shift_type=SHIFT_EVENING,
  146. capacity=2,
  147. del_flag=0,
  148. )
  149. user = SimpleNamespace(
  150. id="u1",
  151. tenant_no="t1",
  152. nick_name="李四",
  153. user_no="lisi",
  154. status="1",
  155. del_flag=0,
  156. )
  157. existing = SimpleNamespace(id="a1", user_id="u1", del_flag=0)
  158. day_q = MagicMock()
  159. day_q.filter.return_value.with_for_update.return_value.first.return_value = day
  160. slot_q = MagicMock()
  161. slot_q.filter.return_value.with_for_update.return_value.first.return_value = slot
  162. user_q = MagicMock()
  163. user_q.filter.return_value.first.return_value = user
  164. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  165. role_q = MagicMock()
  166. role_q.filter.return_value.first.return_value = role
  167. ur_q = MagicMock()
  168. ur_q.filter.return_value.first.return_value = SimpleNamespace(user_id="u1", role_id=DUTY_STAFF_ROLE_ID)
  169. assign_calls = {"n": 0}
  170. def query_side_effect(model):
  171. name = getattr(model, "__name__", str(model))
  172. if name == "DutyDay":
  173. return day_q
  174. if name == "DutySlot":
  175. return slot_q
  176. if name == "SysUser":
  177. return user_q
  178. if name == "SysRole":
  179. return role_q
  180. if name == "SysUserRole":
  181. return ur_q
  182. aq = MagicMock()
  183. # first: duplicate check .first(); later: count
  184. assign_calls["n"] += 1
  185. aq.filter.return_value.first.return_value = existing
  186. aq.filter.return_value.count.return_value = 1
  187. return aq
  188. db.query.side_effect = query_side_effect
  189. with pytest.raises(DutyBizError, match="已报名"):
  190. grab(db, "tok", SHIFT_EVENING, "u1")
  191. def test_save_day_rejects_shrink_below_grab_count():
  192. """缩容:已有 1 人抢班时 capacity=1 且再指定 1 人应失败。"""
  193. db = MagicMock()
  194. day = SimpleNamespace(
  195. id="day1",
  196. duty_date=date(2026, 8, 20),
  197. access_token="tok",
  198. link_status=LINK_OPEN,
  199. tenant_no="t1",
  200. del_flag=0,
  201. update_by=None,
  202. update_time=None,
  203. )
  204. slot = SimpleNamespace(
  205. id="slot1",
  206. duty_day_id="day1",
  207. shift_type=SHIFT_EVENING,
  208. capacity=2,
  209. del_flag=0,
  210. order_num=1,
  211. update_by=None,
  212. update_time=None,
  213. )
  214. grab_row = SimpleNamespace(
  215. id="a1",
  216. duty_slot_id="slot1",
  217. source=SOURCE_GRAB,
  218. del_flag=0,
  219. update_by=None,
  220. update_time=None,
  221. )
  222. day_q = MagicMock()
  223. day_q.filter.return_value.first.return_value = day
  224. slot_list_q = MagicMock()
  225. slot_list_q.filter.return_value.all.return_value = [slot]
  226. assign_q = MagicMock()
  227. assign_q.filter.return_value.all.return_value = [grab_row]
  228. count_q = MagicMock()
  229. count_q.filter.return_value.count.return_value = 1
  230. def query_side_effect(model):
  231. name = getattr(model, "__name__", "")
  232. if name == "DutyDay":
  233. return day_q
  234. if name == "DutySlot":
  235. return slot_list_q
  236. if name == "DutyAssignment":
  237. # first call in loop may be count, then all
  238. m = MagicMock()
  239. m.filter.return_value.count.return_value = 1
  240. m.filter.return_value.all.return_value = [grab_row]
  241. return m
  242. return MagicMock()
  243. db.query.side_effect = query_side_effect
  244. body = DutyDaySaveBody(
  245. dutyDate=date(2026, 8, 20),
  246. slots=[
  247. DutySlotSaveIn(
  248. shiftType=SHIFT_EVENING,
  249. capacity=1,
  250. assignments=[
  251. DutyAssignmentIn(source="assign", userId="u1", personName="张三")
  252. ],
  253. )
  254. ],
  255. )
  256. with pytest.raises(DutyBizError, match="超过名额|缩容|报名"):
  257. save_day(db, "t1", {"user_id": "op1"}, body)
  258. def test_resolve_duty_staff_role_id_by_fixed_id():
  259. db = MagicMock()
  260. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID, role_name=DUTY_STAFF_ROLE_NAME, del_flag=0)
  261. q = MagicMock()
  262. q.filter.return_value.first.return_value = role
  263. db.query.return_value = q
  264. assert resolve_duty_staff_role_id(db, "shanxia2.0") == DUTY_STAFF_ROLE_ID
  265. def test_list_duty_staff_users_empty_when_no_role():
  266. db = MagicMock()
  267. q = MagicMock()
  268. q.filter.return_value.first.return_value = None # resolve role → None twice
  269. db.query.return_value = q
  270. assert list_duty_staff_users(db, "t1") == []
  271. def test_assert_user_is_duty_staff_rejects_without_role():
  272. db = MagicMock()
  273. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  274. role_q = MagicMock()
  275. role_q.filter.return_value.first.return_value = role
  276. ur_q = MagicMock()
  277. ur_q.filter.return_value.first.return_value = None
  278. def query_side_effect(model):
  279. name = getattr(model, "__name__", "")
  280. if name == "SysRole":
  281. return role_q
  282. if name == "SysUserRole":
  283. return ur_q
  284. return MagicMock()
  285. db.query.side_effect = query_side_effect
  286. with pytest.raises(DutyBizError, match="值班人员"):
  287. assert_user_is_duty_staff(db, "t1", "u1")
  288. def test_grab_rejects_non_duty_staff():
  289. db = MagicMock()
  290. day = SimpleNamespace(
  291. id="day1",
  292. tenant_no="t1",
  293. link_status=LINK_OPEN,
  294. duty_date=date(2026, 8, 20),
  295. access_token="tok",
  296. del_flag=0,
  297. )
  298. user = SimpleNamespace(
  299. id="u1",
  300. tenant_no="t1",
  301. nick_name="李四",
  302. user_no="lisi",
  303. status="1",
  304. del_flag=0,
  305. )
  306. day_q = MagicMock()
  307. day_q.filter.return_value.with_for_update.return_value.first.return_value = day
  308. user_q = MagicMock()
  309. user_q.filter.return_value.first.return_value = user
  310. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  311. role_q = MagicMock()
  312. role_q.filter.return_value.first.return_value = role
  313. ur_q = MagicMock()
  314. ur_q.filter.return_value.first.return_value = None
  315. def query_side_effect(model):
  316. name = getattr(model, "__name__", "")
  317. if name == "DutyDay":
  318. return day_q
  319. if name == "SysUser":
  320. return user_q
  321. if name == "SysRole":
  322. return role_q
  323. if name == "SysUserRole":
  324. return ur_q
  325. return MagicMock()
  326. db.query.side_effect = query_side_effect
  327. with pytest.raises(DutyBizError, match="值班人员"):
  328. grab(db, "tok", SHIFT_EVENING, "u1")
  329. def test_save_day_grandfathers_existing_assign_without_role():
  330. """历史指定用户无值班人员角色时,原样再保存不得因角色校验失败。"""
  331. db = MagicMock()
  332. day = SimpleNamespace(
  333. id="day1",
  334. duty_date=date(2026, 8, 20),
  335. access_token="tok",
  336. link_status=LINK_OPEN,
  337. tenant_no="t1",
  338. del_flag=0,
  339. update_by=None,
  340. update_time=None,
  341. )
  342. slot = SimpleNamespace(
  343. id="slot1",
  344. duty_day_id="day1",
  345. shift_type=SHIFT_EVENING,
  346. capacity=2,
  347. del_flag=0,
  348. order_num=1,
  349. update_by=None,
  350. update_time=None,
  351. )
  352. old_assign = SimpleNamespace(
  353. id="a_old",
  354. duty_slot_id="slot1",
  355. source=SOURCE_ASSIGN,
  356. user_id="u_old",
  357. person_name="老员工",
  358. del_flag=0,
  359. update_by=None,
  360. update_time=None,
  361. )
  362. day_q = MagicMock()
  363. day_q.filter.return_value.first.return_value = day
  364. slot_list_q = MagicMock()
  365. slot_list_q.filter.return_value.all.return_value = [slot]
  366. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  367. role_q = MagicMock()
  368. role_q.filter.return_value.first.return_value = role
  369. ur_q = MagicMock()
  370. ur_q.filter.return_value.first.return_value = None # 无角色关联
  371. user_q = MagicMock()
  372. user_q.filter.return_value.first.return_value = SimpleNamespace(
  373. id="u_old", tenant_no="t1", del_flag=0, status="1"
  374. )
  375. def query_side_effect(model):
  376. name = getattr(model, "__name__", "")
  377. if name == "DutyDay":
  378. return day_q
  379. if name == "DutySlot":
  380. return slot_list_q
  381. if name == "DutyAssignment":
  382. m = MagicMock()
  383. m.filter.return_value.count.return_value = 1
  384. m.filter.return_value.all.return_value = [old_assign]
  385. return m
  386. if name == "SysRole":
  387. return role_q
  388. if name == "SysUserRole":
  389. return ur_q
  390. if name == "SysUser":
  391. return user_q
  392. return MagicMock()
  393. db.query.side_effect = query_side_effect
  394. body = DutyDaySaveBody(
  395. dutyDate=date(2026, 8, 20),
  396. slots=[
  397. DutySlotSaveIn(
  398. shiftType=SHIFT_EVENING,
  399. capacity=2,
  400. assignments=[
  401. DutyAssignmentIn(source="assign", userId="u_old", personName="老员工")
  402. ],
  403. )
  404. ],
  405. )
  406. # 不得因「无值班人员角色」抛错;序列化侧 mock 足够跑完即可
  407. result = save_day(db, "t1", {"user_id": "op1"}, body)
  408. assert result is not None
  409. db.commit.assert_called()
  410. def test_save_day_rejects_new_assign_without_role():
  411. """新指定用户无值班人员角色时必须拒绝。"""
  412. db = MagicMock()
  413. day = SimpleNamespace(
  414. id="day1",
  415. duty_date=date(2026, 8, 20),
  416. access_token="tok",
  417. link_status=LINK_OPEN,
  418. tenant_no="t1",
  419. del_flag=0,
  420. update_by=None,
  421. update_time=None,
  422. )
  423. slot = SimpleNamespace(
  424. id="slot1",
  425. duty_day_id="day1",
  426. shift_type=SHIFT_EVENING,
  427. capacity=2,
  428. del_flag=0,
  429. order_num=1,
  430. update_by=None,
  431. update_time=None,
  432. )
  433. old_assign = SimpleNamespace(
  434. id="a_old",
  435. duty_slot_id="slot1",
  436. source=SOURCE_ASSIGN,
  437. user_id="u_old",
  438. person_name="老员工",
  439. del_flag=0,
  440. update_by=None,
  441. update_time=None,
  442. )
  443. day_q = MagicMock()
  444. day_q.filter.return_value.first.return_value = day
  445. slot_list_q = MagicMock()
  446. slot_list_q.filter.return_value.all.return_value = [slot]
  447. role = SimpleNamespace(id=DUTY_STAFF_ROLE_ID)
  448. role_q = MagicMock()
  449. role_q.filter.return_value.first.return_value = role
  450. ur_q = MagicMock()
  451. ur_q.filter.return_value.first.return_value = None
  452. user_q = MagicMock()
  453. user_q.filter.return_value.first.return_value = SimpleNamespace(
  454. id="u_new", tenant_no="t1", del_flag=0, status="1"
  455. )
  456. def query_side_effect(model):
  457. name = getattr(model, "__name__", "")
  458. if name == "DutyDay":
  459. return day_q
  460. if name == "DutySlot":
  461. return slot_list_q
  462. if name == "DutyAssignment":
  463. m = MagicMock()
  464. m.filter.return_value.count.return_value = 1
  465. m.filter.return_value.all.return_value = [old_assign]
  466. return m
  467. if name == "SysRole":
  468. return role_q
  469. if name == "SysUserRole":
  470. return ur_q
  471. if name == "SysUser":
  472. return user_q
  473. return MagicMock()
  474. db.query.side_effect = query_side_effect
  475. body = DutyDaySaveBody(
  476. dutyDate=date(2026, 8, 20),
  477. slots=[
  478. DutySlotSaveIn(
  479. shiftType=SHIFT_EVENING,
  480. capacity=2,
  481. assignments=[
  482. DutyAssignmentIn(source="assign", userId="u_new", personName="新员工")
  483. ],
  484. )
  485. ],
  486. )
  487. with pytest.raises(DutyBizError, match="值班人员"):
  488. save_day(db, "t1", {"user_id": "op1"}, body)